feat(http): expose tls mod and add custom error to allow using other tls implementation#1199
Open
feat(http): expose tls mod and add custom error to allow using other tls implementation#1199
Conversation
joelwurtz
force-pushed
the
feat/allow-custom-tls
branch
from
91863a7 to
2a06671
Compare
…tls implementation
joelwurtz
force-pushed
the
feat/allow-custom-tls
branch
from
2a06671 to
46123bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am currently trying to implement a way to have automatic certificate with acme and xitca and this need to have a specific tls acceptor (to allow lazy config acceptor like it's done in tokio rustls : cf https://tg-rs.github.io/carapax/tokio_rustls/struct.LazyConfigAcceptor.html )
Goal is to make a tls connection waiting when a certificate is being created (so there is no insecure / dropped connection on start)
There is already the
with_tlsmethod on the HttpServiceBuilder but this need to expose a TlsError which is not public, this PR fix that by making it public and allow any errors in it