feat(client): check correct state of h1 stream before sending request#1209
Open
feat(client): check correct state of h1 stream before sending request#1209
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
joelwurtz
force-pushed
the
feat/h1-check-eof
branch
3 times, most recently
from
6745229 to
1efa973
Compare
saltman007web
approved these changes
Mar 13, 2025
…, add middleware to retry sending request for this error
joelwurtz
force-pushed
the
feat/h1-check-eof
branch
from
1efa973 to
a134525
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replace #1176
A different approach is used here
Mainly we try to read 1 byte from the stream in a sync way, since we didn't send anything yet we should receive a WouldBlock io error, if we doesn't receive this it either means :
Retrying here should be safer since we don't consume request, i still use a middleware so user will opt in for this feature
I only handled the h1 connection closed error here, we could add other cases later when request could be retried safely in those cases