This repository was archived by the owner on May 22, 2020. It is now read-only.
Open
Conversation
openfin-github-bot
bot
added
the
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
8 tasks
pbaize
reviewed
Oct 8, 2019
src/browser/api/window.js
Outdated
| WebContents.executeJavascript(browserWindow.webContents, code, callback); | ||
| }; | ||
|
|
||
| Window.findInPage = function(identity, searchTerm, options) { |
Member
Author
There was a problem hiding this comment.
actually no, removing them now
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
Contributor
|
Docs? |
Member
Author
|
Docs have been added to js-adapter |
| const { payload } = message; | ||
| const { searchTerm, options } = payload; | ||
| const dataAck = Object.assign({}, successAck); | ||
| const windowIdentity = getTargetWindowIdentity(payload); |
Contributor
There was a problem hiding this comment.
Question: Is there a reason we wouldn't want to use the identity here instead of the payload identity? Probably doesn't make a functional difference tho
Member
Author
There was a problem hiding this comment.
All the other functions are using the payload one, didn't see a need to change that.
Member
There was a problem hiding this comment.
Identity (First param) is the requesting identity, the identity in the payout is the target.
Member
|
Will a findInPage action generate a single event or multiple? |
Member
Author
|
findInPage now returns a promise with the request results generated by the 'found-in-page' event. I've also left the event in as it could be useful as well. |
openfin-github-bot
bot
added
auto testing started
Git
Asars used for testingTest results
|
openfin-github-bot
bot
added
auto testing done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This exposes Electron's Find In Page API.
Checklist
npm testpassesTEST
Release Notes
Notes:
Added API to find and highlight text on a page.