Cashu bolt12 send and receive with sending to bip353 #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesimplekid
force-pushed
the
bolt12
branch
2 times, most recently
from
c0f117d to
a8d49b3
Compare
Contributor
benthecarman
left a comment
benthecarman
left a comment
There was a problem hiding this comment.
some preliminary review
|
|
||
| // Use CDK's BIP-353 melt flow to get a quote | ||
| let quote = client | ||
| .melt_bip353_quote(&address, cdk::Amount::from(amount_msats)) |
Contributor
There was a problem hiding this comment.
this may be a problem, i am guessing this won't be over tor
Contributor
Author
There was a problem hiding this comment.
Yeah, good point it just used trust_dns_resolver. Just remove it or disable it if tor is enabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.