feat: Implement OIDC for secure CI/CD and centralize AWS configuration#3
Merged
Hectormalvarez merged 2 commits intomainfrom Jun 2, 2025
Merged
feat: Implement OIDC for secure CI/CD and centralize AWS configuration#3Hectormalvarez merged 2 commits intomainfrom
Hectormalvarez merged 2 commits intomainfrom
Conversation
Removes hardcoded domain, base domain, and hosted zone IDs from `config.ts`. These values are now strictly sourced from environment variables (e.g., `AWS_DOMAIN_NAME_DEV`, `AWS_HOSTED_ZONE_ID_PROD`) for enhanced security and maintainability. Adds runtime validation to ensure required environment variables are present for each deployment environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to our deployment pipeline, focusing on security, maintainability, and automation for both development and production environments.
Key Changes & Improvements:
Migrated to OIDC for AWS Authentication:
Centralized AWS Configuration:
config.ts.config.tsto ensure all required environment variables are present during build/deployment.Implemented Production Deployment Workflow:
mainbranch, promoting a controlled release process.Why these changes were made:
How to Test:
devbranch and verify that thedeploy_devworkflow runs successfully and updates the development website.mainbranch and verify that thedeploy_prodworkflow runs successfully and updates the production website.