Feature from file #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilbert Sanchez <me@gilbertsanchez.com>
Signed-off-by: Gilbert Sanchez <me@gilbertsanchez.com>
Test Results 3 files 237 suites 6s ⏱️ Results for commit a77add4. ♻️ This comment has been updated with latest results. |
Signed-off-by: Gilbert Sanchez <me@gilbertsanchez.com>
* Refactored `Read-FeatureFlag` function to streamline processing. * Added error handling for invalid file paths. * Introduced unit tests for `Read-FeatureFlag` to ensure reliability. * Created a sample `FeatureFlag.json` for testing purposes.
* Implemented tests to verify the functionality of new file creation cmdlets. * Ensured that the tests cover the creation of conditions and rules. * Mocked necessary functions to isolate tests and improve reliability.
* Updated the output type of `Read-FeatureFlag` function to `[PropertySet]` for accuracy. * Ensures proper type handling when reading feature flags from disk.
* Refactored the test setup to directly assign the `$script:GatekeeperConfiguration` variable. * Removed unnecessary `InModuleScope` for mocking `Get-ConfigurationPath`. * Ensured the test paths are correctly set for feature flag and property set directories.
* Refactored the mock for `Get-PropertySetFolder` to ensure consistent test behavior. * Updated the `$script:GatekeeperConfiguration` to include `FilePaths` for better clarity and organization.
* Added `-ModuleName` to mock commands for better clarity and context. * Ensured that the mocks are correctly scoped to the `$env:BHProjectName`.
* Updated the output type annotation from `[PropertySet]` to `[FeatureFlag]` for the `Read-FeatureFlag` function. * This change ensures that the function correctly reflects the type of object it returns.
* Ensure necessary directories for `PropertySet`, `FeatureFlags`, and `Configuration` are created before tests run. * Update `$global:GatekeeperConfiguration` to reflect the correct scope for configuration settings.
* Updated CHANGELOG to reflect the new version. * Incremented `ModuleVersion` to '0.1.1' in the module manifest. * Corrected file path casing in test for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: