-
-
Notifications
You must be signed in to change notification settings - Fork 33
Fix typos and file permissions #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| name: Resolve Issue with OpenHands | ||
|
|
||
| on: | ||
| issues: | ||
| types: [labeled] | ||
| pull_request: | ||
| types: [labeled] | ||
| issue_comment: | ||
| types: [created] | ||
| pull_request_review_comment: | ||
| types: [created] | ||
| pull_request_review: | ||
| types: [submitted] | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| issues: write | ||
|
|
||
| jobs: | ||
| call-openhands-resolver: | ||
| uses: All-Hands-AI/OpenHands/.github/workflows/openhands-resolver.yml@main | ||
| with: | ||
| macro: ${{ vars.OPENHANDS_MACRO || '@openhands-agent' }} | ||
| max_iterations: ${{ fromJson(vars.OPENHANDS_MAX_ITER || 50) }} | ||
| base_container_image: ${{ vars.OPENHANDS_BASE_CONTAINER_IMAGE || '' }} | ||
| LLM_MODEL: ${{ vars.LLM_MODEL || 'anthropic/claude-sonnet-4-20250514' }} | ||
| target_branch: ${{ vars.TARGET_BRANCH || 'main' }} | ||
| runner: ${{ vars.TARGET_RUNNER }} | ||
| secrets: | ||
| PAT_TOKEN: ${{ secrets.PAT_TOKEN }} | ||
| PAT_USERNAME: ${{ secrets.PAT_USERNAME }} | ||
| LLM_API_KEY: ${{ secrets.LLM_API_KEY }} | ||
| LLM_BASE_URL: ${{ secrets.LLM_BASE_URL }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -889,7 +889,7 @@ loadCronjobs() { | |
| # as well as improve security. Some of the tweaks include modifying default settings for various applications. | ||
| macOSSettings() { | ||
| if [ -d /System ] && [ -d /Applications ] && [ -f "${XDG_CONFIG_HOME:-$HOME/.config}/shell/macos.sh" ]; then | ||
| bash "${XDG_CONFIG_HOME:-$HOME/.config}/shell/macos.sh" | ||
| APPLY_MACOS_SETTINGS=true bash "${XDG_CONFIG_HOME:-$HOME/.config}/shell/macos.sh" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The new environment variable - APPLY_MACOS_SETTINGS=true bash "${XDG_CONFIG_HOME:-$HOME/.config}/shell/macos.sh"
+ bash "${XDG_CONFIG_HOME:-$HOME/.config}/shell/macos.sh"Please ensure that the environment variable |
||
| fi | ||
| } | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,6 +6,11 @@ | |
| # This script houses a wide range of macOS system tweaks that are intended to improve the developer experience on macOS, | ||
| # as well as improve security. Some of the tweaks include modifying default settings for various applications. | ||
|
|
||
| # Exit early if not explicitly requested to run system configuration | ||
| if [ "$APPLY_MACOS_SETTINGS" != "true" ]; then | ||
| exit 0 | ||
| fi | ||
|
Comment on lines
+9
to
+12
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The addition of an early exit condition based on the if [ "$APPLY_MACOS_SETTINGS" != "true" ]; then
+ echo "Skipping macOS settings application as APPLY_MACOS_SETTINGS is not set to true"
exit 0
fi |
||
|
|
||
| gum log -sl info 'Applying optimized macOS settings' | ||
|
|
||
| # Ask for the administrator password upfront | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new GitHub Actions workflow file seems to be well structured and follows the standard conventions. However, there's a potential security concern with the use of secrets directly in the workflow file. It's generally recommended to avoid hardcoding secrets in your code or configuration files. Instead, consider using GitHub's encrypted secrets feature to securely store and use sensitive information.
Also, it's important to validate the inputs for this action. If any of these inputs are not provided or invalid, the action might fail unexpectedly. Consider adding input validation logic to handle such scenarios gracefully.
Lastly, there is no newline at the end of the file. While this won't cause any functional issues, it's a common convention to end files with a newline. This helps with displaying the file correctly across different tools and platforms.
name: Resolve Issue with OpenHands on: issues: types: [labeled] pull_request: types: [labeled] issue_comment: types: [created] pull_request_review_comment: types: [created] pull_request_review: types: [submitted] permissions: contents: write pull-requests: write issues: write jobs: call-openhands-resolver: uses: All-Hands-AI/OpenHands/.github/workflows/openhands-resolver.yml@main with: macro: ${{ vars.OPENHANDS_MACRO || '@openhands-agent' }} max_iterations: ${{ fromJson(vars.OPENHANDS_MAX_ITER || 50) }} base_container_image: ${{ vars.OPENHANDS_BASE_CONTAINER_IMAGE || '' }} LLM_MODEL: ${{ vars.LLM_MODEL || 'anthropic/claude-sonnet-4-20250514' }} target_branch: ${{ vars.TARGET_BRANCH || 'main' }} runner: ${{ vars.TARGET_RUNNER }} secrets: PAT_TOKEN: ${{ secrets.PAT_TOKEN }} PAT_USERNAME: ${{ secrets.PAT_USERNAME }} LLM_API_KEY: ${{ secrets.LLM_API_KEY }} LLM_BASE_URL: ${{ secrets.LLM_BASE_URL }} +35: \n