Changes on SCORSA for ACM Summer School 2019#1
Open
felipeportella wants to merge 1 commit intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added all the code changes we made for the ACM Summer School. Most notably was the upgrade to Python 3 which included some file renaming.
Probably you don't want to merge the policy.py as it is now, as we replaced the logic by a random scheduling policy (and has some code hints for the students quickly edit the file). Anyway, keeping the random policy could be interesting for benchmarking against other policies implementations (maybe kept it as a separate function and add in the config.ini the option to choose the policy)