Switch asColorable in favor of LeatherArmorMeta's color Property#32
Open
MattDeWeerd wants to merge 1 commit intoHibiscusMC:masterfrom
Open
Switch asColorable in favor of LeatherArmorMeta's color Property#32MattDeWeerd wants to merge 1 commit intoHibiscusMC:masterfrom
MattDeWeerd wants to merge 1 commit intoHibiscusMC:masterfrom
Conversation
Author
|
Note: I did attempt to add a case for if the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed:
LeatherArmorMeta'scolorpropertyWhy this was changed
subColorItem.itemStack.asColorable()returned null.guiOutputto return an itemStack that did not have its color changed.Things To Consider
LeatherArmorMeta, the subcolor menu items must beLEATHER_HORSE_ARMORPOTIONcannot be used as the cosmetic materialPOTIONcausing issues with HMCColorThings To Look Out For