This repository was archived by the owner on Nov 10, 2018. It is now read-only.
Open
Conversation
gmichalo
approved these changes
Jul 7, 2018
|
Not sure you want to do this. You use setup.py to install a local copy of holoclean, the equivalent of pip install holoclean. Everytime you make a dev change you can run a quick python setup.py install to update build artifacts in your env. This means you also don’t need a relative path to the holoclean directory every time you need to use it. It’s also needed to upload anything to PyPi (which imo should be done). I use it in my dev workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the setup.py in the root directory. I'm not sure how it works and there are no instructions on the README. Either deleting it with this PR or someone who knows what it does, tests it and adds to the README.