allow custom HDF5 data types in h5createDataset and h5writeDataset #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
AFAICT the CI is failing somewhere in the |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #130 +/- ##
==========================================
- Coverage 79.03% 78.70% -0.34%
==========================================
Files 36 36
Lines 1994 2005 +11
==========================================
+ Hits 1576 1578 +2
- Misses 418 427 +9
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This useful when one has a custom type, but still wants to use the default HDF5 spaces, DCPLs etc. that these functions provide. For example, when writing logical vectors that are compatible with Python's h5py, one needs to create a custom enum type with
H5Tenum_create.