Skip to content

Clarify the optional sections in the global PR template#8

Merged
DougReeder merged 1 commit intomainfrom
pr-template-clarify-optional
Feb 19, 2026
Merged

Clarify the optional sections in the global PR template#8
DougReeder merged 1 commit intomainfrom
pr-template-clarify-optional

Conversation

@Exairnous
Copy link
Member

What?

Prefixes the optional section descriptions in pull_request_template.md with "OPTIONAL — " and provides more details on what the sections should be used for as well as what to do if they aren't applicable to the PR.

Why?

The observed use of these sections has been inconsistent and not entirely aligned with their original intent.

Examples

N/A

How to test

  1. This can mostly be tested by just reading the changes, but if you want to see the full preview, click on the three dots in the top right corner of the file diff and select "View file" or copy the modified pull request template into a GitHub comment and switch it to "Preview".

Documentation of functionality

No functionality has changed, so no documentation update is needed.

Limitations

None.

Alternative implementations considered

Adding more comprehensive examples on what should go in these sections to the pull request guidelines in the policies-procedures-guidelines repo was considered (and will probably be done eventually in addition to this), but people won't always have the pull request guidelines open when making pull requests, while this gets the information right where they need it.

Open questions

  • Are any of the descriptions too long now?
  • Does this "restrict" people from adding any information that might be useful?
  • Is there anything that is still confusing to anyone?
  • Can any of the headings be improved by adding additional words to them?

Additional details or related context

Having submitters put "None" or "N/A" in sections, rather than leaving them blank or removing them (except potentially for the "Examples" section), ensures that the reviewer will know they haven't been missed or deleted accidentally, or that something else hasn't gone wrong.

This PR came about as a result of discussions at the 2026-02-10 Dev Meetup. Notes - Hubs Dev Meetup Google Doc

Discussion welcome.

What: Prefixes the optional section descriptions in pull_request_template.md with "OPTIONAL — " and provides more details on what the sections should be used for as well as what to do if they aren't applicable to the PR.

Why: The observed use of these sections has been inconsistent and not entirely aligned with their original intent.

Note: Having submitters put "None" or "N/A" in sections, rather than leaving them blank or removing them (except potentially for the "Examples" section), ensures that the reviewer will know they haven't been missed or deleted accidentally, or that something else hasn't gone wrong.
Copy link
Member

@DougReeder DougReeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me, they seem a trifle wordy, but let's do this and see how it works out.

@hobbs-Hobbler
Copy link

LGTM. Especially like the alternatives explanation as it really helps me.

@Exairnous
Copy link
Member Author

Excellent! Thank you. Let's go with merging it then.

@DougReeder DougReeder merged commit ea92e8a into main Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments