Feat/mdma packet2 #540
Open
Feat/mdma packet2 #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be problematic with resource management.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…-LIB into feat/Promises
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… refactor/MPUManager
Removed the NODES_MAX definition and related comments.
…symbol, to ensure initialization order doesn't matter
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packets that get built and parsed by using the mdma. This allows asynchronous handling of packets, as well as liberating cpu cycles.
The packets are declared on compile-time and then retrieved in runtime. This way, the nodes can be allocated through the MPU.
It would be lovely to be able to pass the pointers on compile-time, and it could be done by passing MPU::Buffer, but that would mean that we could only create packets with modules implemented with the new system, so nothing of that for now. It remains an idea worth exploring though. Imagine, pointers on compile-time, it's pretty neat.
The asynchronous model the packets use is that of a bool* that gets set to true when the transfer completes, simple, efficient, can abstract later when needed.