Fw 301/execute code gen on cmake (Now working) #54
Conversation
…/HyperloopUPV-H8/template-project into FW-301/Execute_Code_gen_on_cmake
Cantonplas
changed the title
There was a problem hiding this comment.
Why is there a void .gitignore here?
There was a problem hiding this comment.
If you delete all the generated code and upload it to the repo the file will be deleted, and if the file is deleted the program crash. So adding a. gitignore makes it so that the file doesnt get deleted and still can be uploaded
There was a problem hiding this comment.
I still dont get the point.
jorgesg82
left a comment
jorgesg82
left a comment
There was a problem hiding this comment.
Add all generated code in a .gitignore
oganigl
left a comment
oganigl
left a comment
There was a problem hiding this comment.
For me looks good, I just looked over it.
jdmarmen
left a comment
jdmarmen
left a comment
There was a problem hiding this comment.
Great job, just one thing, as you already generate the function definitions for the callbacks in the orders I would also consider to generate the flag for each order. We always use those callbacks only to change the value of the flag, so rn the user also needs to define that flag and its also a repetitive thing, what do you think @jorgesg82 ?
| board_instance = BoardDescription(board, b,JSONpath) | ||
| globals()[board] = board_instance | ||
| else: | ||
| print("Board not found, exiting...") |
There was a problem hiding this comment.
| print("Board not found, exiting...") | |
| print(f "Board {board} not found, exiting...") |
Works correctly, now when you build the proyect it will create the packets and orders from your board.
You need to change the board name on the cmake tho