refactor(examples): update CSVSampleStores with old keys#611
refactor(examples): update CSVSampleStores with old keys#611AlessandroPomponio wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
|
I created the following script and loaded and dumped the CSVs: from pathlib import Path
import yaml
from orchestrator.core.samplestore.config import SampleStoreConfiguration
from orchestrator.utilities.output import pydantic_model_as_yaml
to_load = Path("examples/pfas-generative-models/gen_models_molgx_test_sample_store.yaml")
sample_store = SampleStoreConfiguration.model_validate(
yaml.safe_load(to_load.read_text())
)
to_load.write_text(pydantic_model_as_yaml(sample_store, exclude_unset=True, exclude_none=True)) |
|
We still need to update ado/website/docs/actuators/replay.md Lines 56 to 64 in 03f9f99 |
Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
|
@michael-johnston could you suggest a fix for the above? I think the new field is |
|
Yes should be |
michael-johnston
left a comment
There was a problem hiding this comment.
Is anything using sample_store_resource.json?
Seems strange it could be wrong and used?
I see this shows a problem with how we test ml_multi_cloud.
At one stage we ran tests using the files in the example folder - however this meant that we need to use absolute path for the CSV file in the example, which mean the user had to change it to run the example.
To fix this we create a separate version of the ml_multicloud_sample_store.yaml for use in unit-tests -however also update the end-to-end test in tox to use this file (as the end to end text was running from route of repo). This meant the actual example was no longer tested at all.
I think we need to also change the tox test to use the actual example file - either by running in the ml_multi_cloud example directory or by adding an override of the CSV path.
Looks like the
It's not "wrong" because it's still an allowed syntax, we should check if there were some warnings about it though
I don't think this is the case - we have the |
Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
No description provided.