Exploring jenkins pipeline for PR-Preview feature#282
Draft
adarshagrawal38 wants to merge 9 commits intoIBM:mainfrom
Draft
Exploring jenkins pipeline for PR-Preview feature#282adarshagrawal38 wants to merge 9 commits intoIBM:mainfrom
adarshagrawal38 wants to merge 9 commits intoIBM:mainfrom
Conversation
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
4116f57 to
22e2d5d
Compare
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
iv1111
reviewed
Feb 11, 2026
Jenkinsfile
Outdated
| // Get the tag from Makefile | ||
| def tag = sh(script: "make image-tag REGISTRY=${localRegistry}", returnStdout: true).trim() | ||
| imagePath = "${localRegistry}/${imageName}:${tag}" | ||
| echo "Backend image set to ${imagePath}" |
Collaborator
There was a problem hiding this comment.
Why is it called Backend image? Isn't function applicable to any image?
Member
Author
There was a problem hiding this comment.
yes right I will rephrase the log
iv1111
reviewed
Feb 11, 2026
Collaborator
iv1111
left a comment
There was a problem hiding this comment.
Looks lgtm, will re-review once it is tested and promoted to a PR.
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
256039e to
9e1c625
Compare
iv1111
reviewed
Feb 11, 2026
Collaborator
There was a problem hiding this comment.
I think we should get PR merged without GH pipeline yet.
Member
Author
There was a problem hiding this comment.
yeah I will remove GH pipeline
Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>
5ec7aaf to
dec32e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on jenkins pipeline to deploy code changes of PR or commit hash to a spyre machine
Pipeline URL - > Jenkins