Application templates command to support Podman and Openshift#320
Open
Application templates command to support Podman and Openshift#320
Conversation
Signed-off-by: mayuka-c <Mayuka.C@ibm.com>
Signed-off-by: mayuka-c <Mayuka.C@ibm.com>
mayuka-c
force-pushed
the
app-templates-commadn
branch
from
6a1e914 to
60d2370
Compare
mayuka-c
commented
Feb 13, 2026
Comment on lines
-31
to
-45
| // NewFactoryFromEnv creates a factory using environment variable or default. | ||
| func NewFactoryFromEnv() *RuntimeFactory { | ||
| runtimeType := types.RuntimeTypePodman // default | ||
| if envRuntime := os.Getenv(EnvRuntimeType); envRuntime != "" { | ||
| rt := types.RuntimeType(strings.ToLower(envRuntime)) | ||
| if rt.Valid() { | ||
| runtimeType = rt | ||
| } else { | ||
| logger.Warningf("Invalid runtime type in %s: %s, using default: %s\n", | ||
| EnvRuntimeType, envRuntime, types.RuntimeTypePodman) | ||
| } | ||
| } | ||
|
|
||
| return NewRuntimeFactory(runtimeType) | ||
| } |
Member
Author
There was a problem hiding this comment.
Removed this as this is no where used and we support only runtime as flag
yussufsh
requested changes
Feb 13, 2026
| for k, v := range appTemplatesParametersWithDescription { | ||
| logger.Infoln("\t" + k + ": " + v) | ||
| } | ||
| fmt.Println() |
mkumatag
requested changes
Feb 16, 2026
| @@ -1,5 +1,3 @@ | |||
| imagePullPolicy: IfNotPresent | |||
Member
There was a problem hiding this comment.
I remember we were using this somewhere? don't we need this variable?
| Use: "templates", | ||
| Short: "Lists the offered application templates and their supported parameters", | ||
| Long: `Retrieves information about the offered application templates and their supported parameters`, | ||
| PreRunE: func(cmd *cobra.Command, args []string) error { |
Member
There was a problem hiding this comment.
any reason for removing this and exposing the usage message always?
| return fmt.Errorf("failed to list application template values: %w", err) | ||
| logger.Errorf("failed to list application template values: %v", err) | ||
|
|
||
| continue |
Member
There was a problem hiding this comment.
any reason for continuing even after the failure?
| return fmt.Errorf("failed to load application metadata: %w", err) | ||
| logger.Errorf("failed to load application metadata: %v", err) | ||
|
|
||
| continue |
Member
There was a problem hiding this comment.
any reason for continuing even after the failure?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.