Skip to content

refactor bootstrap to integrate multiple runtimes#322

Open
Shubhamag12 wants to merge 1 commit intoIBM:mainfrom
Shubhamag12:refactor-bootstrap
Open

refactor bootstrap to integrate multiple runtimes#322
Shubhamag12 wants to merge 1 commit intoIBM:mainfrom
Shubhamag12:refactor-bootstrap

Conversation

@Shubhamag12
Copy link
Contributor

Part of main...suhailos:project-ai-services:feature/bootstrap-interface-refactoring

Refactor bootstrap to use interface-based design pattern

  • Created Bootstrap interface in internal/pkg/bootstrap/
  • Implemented PodmanBootstrap with all Podman-specific logic
  • Added BootstrapFactory with factory pattern
  • Moved business logic from cmd/bootstrap/ to internal/pkg/bootstrap/
  • Updated cmd/bootstrap commands to use new interface
  • Updated application create command to use bootstrap factory

This refactoring follows the same pattern as the runtime interface, enabling support for multiple runtimes.

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good except one minor comment

@Shubhamag12 Shubhamag12 marked this pull request as ready for review February 16, 2026 06:28
@Shubhamag12 Shubhamag12 force-pushed the refactor-bootstrap branch 2 times, most recently from 3c89024 to 7623292 Compare February 16, 2026 07:03
mkumatag
mkumatag previously approved these changes Feb 16, 2026
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkumatag
Copy link
Member

Please merge post @mayuka-c 's ack.

Signed-off-by: sagarwal-ibm <sagarwal@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants