Open
Conversation
Degilio
force-pushed
the
Add-mvs_command_supprt
branch
from
1441d17 to
1c9fb74
Compare
Create something that hides some of the complexity associated with creating ddd. Signed-off-by: Frank De Gilio <degilio@us.ibm.com>
Removed extra print statement Signed-off-by: Frank De Gilio <degilio@us.ibm.com>
Degilio
force-pushed
the
Add-mvs_command_supprt
branch
from
08fbeb1 to
2aa7283
Compare
Contributor
Author
|
Hey - @AnthonyGiorgio can you review this and let me know? |
AnthonyGiorgio
requested changes
Aug 2, 2023
| dd_list.append(DDStatement("SMPLOGA","DUMMY")) | ||
|
|
||
| # Define the Global CSI | ||
| dd_list.append(DDStatement("SMPCSI",DatasetDefinition("AT4SMP.GLOBAL.CSI"))) |
Member
There was a problem hiding this comment.
This dataset name looks rather specific. Is there a better way than hardcoding it?
Contributor
Author
There was a problem hiding this comment.
We should discuss this. I used what is in the main for my testing. The dataset name is not the only thing that is hard coded. Does it make sense to build a more complex main that takes parameters for all of the hard coded items - Or is it smarter to build a comment section that describes it better. The idea is to get people to use each of the functions rather than use them as part of the main.
Signed-off-by: Frank De Gilio <degilio@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create something that hides some of the complexity associated with creating dds.