fixed Boost::system include for Boost >= 1.89 #27
+14
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! The CI seems to be broken (again:-/), so it's difficult for me to check if your contribution will break older version (such as boost 1.83 that is still used on Ubuntu), before fixing these issues. Conceptually it makes sense, though and your fix might address the issues the CI finds on Mac OS (not sure what's going on for Windows and Linux, yet). |
Author
|
rebased to current head; attempted vibe-fixing linux and windows CI errors. MacOS CI error on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
From Boost 1.89 on, the Boost::system library doesn't exist anymore.
Proposed fix:
Replace
Boost::systemwithBoost::boost.Tested with boost 1.89, python 14.