Conversation
There was a problem hiding this comment.
Pull request overview
This pull request enhances the CLI to support continuing from a checkpoint with a different name than the current training run, and removes epoch-related data from logging in preparation for data mixtures support.
Changes:
- Modified
--continueCLI option to accept string arguments (checkpoint paths or step numbers) instead of just integers - Removed
epochparameter from logging functions and replaced epoch-based progress calculation with step-based progress - Added
set_final_stepmethod to enable accurate progress tracking
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| train.cpp | Updated checkpoint continuation logic to support paths and directory names; removed epoch parameters from function calls; added final step tracking |
| src/training/logging.h | Updated function signatures to remove epoch parameters; renamed mRemainingTokens to mFinalStep; added set_final_step method |
| src/training/logging.cpp | Implemented step-based progress calculation; removed epoch from log output; added set_final_step implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to continue from a checkpoint with a different name than the current training run.
Remove "epoch" data from logging, it isn't really useful and won't generalize well once we add data mixtures.