Skip to content

Conversation

@mtfishman
Copy link
Member

@mtfishman mtfishman commented Jan 5, 2026

To-do:

  • Bring back and test cat (requires adding concatenate back to FunctionImplementations.jl).
  • Code cleanup.
  • Rename [abstract]sparsearrayinterface.jl to [abstract]sparsearraystyle.jl.
  • Change diag_style function signatures from Diagonal to AbstractMatrix.

Closes #82, closes #83.

@mtfishman mtfishman closed this Jan 6, 2026
@mtfishman mtfishman reopened this Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 85.62874% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.95%. Comparing base (4ae766b) to head (d583277).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/map.jl 65.21% 8 Missing ⚠️
src/abstractsparsearray.jl 83.87% 5 Missing ⚠️
src/abstractsparsearraystyle.jl 42.85% 4 Missing ⚠️
src/indexing.jl 94.54% 3 Missing ⚠️
src/sparsearraystyle.jl 91.42% 3 Missing ⚠️
src/wrappers.jl 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   77.59%   78.95%   +1.35%     
==========================================
  Files          12       12              
  Lines         732      784      +52     
==========================================
+ Hits          568      619      +51     
- Misses        164      165       +1     
Flag Coverage Δ
docs 30.54% <43.35%> (+1.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman mtfishman changed the title [WIP] Switch to FunctionImplementations.jl Switch to FunctionImplementations.jl Jan 6, 2026
@mtfishman mtfishman marked this pull request as ready for review January 6, 2026 20:52
@mtfishman mtfishman merged commit 691a0b9 into main Jan 6, 2026
16 checks passed
@mtfishman mtfishman deleted the mf/functionimplementations branch January 6, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants