CMake: require Boost unit_test_framework #10260
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
All packages still build! 🎉 https://git.icinga.com/packages/icinga2/-/pipelines/34928 |
yhabteab
reviewed
Jan 24, 2025
Member
yhabteab
left a comment
yhabteab
left a comment
There was a problem hiding this comment.
Why not just make this search required instead of silently (QUIET) suppressing it?
icinga2/third-party/cmake/BoostTestTargets.cmake
Lines 57 to 59 in 7888366
Al2Klimov
commented
Jan 24, 2025
Member
Author
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
AFAIK this is 3rd party stuff we're just shipping.
| endif() | ||
|
|
||
| find_package(Boost ${BOOST_MIN_VERSION} COMPONENTS coroutine context date_time filesystem iostreams thread system program_options regex REQUIRED) | ||
| find_package(Boost ${BOOST_MIN_VERSION} COMPONENTS coroutine context date_time filesystem iostreams thread system program_options regex unit_test_framework REQUIRED) |
Member
Author
There was a problem hiding this comment.
I'd like a central list where one can look up once what we require.
Member
Even with `-DICINGA2_WITH_TESTS=ON -DBUILD_TESTING=ON` CLion (and likely not only it) doesn't recognize any test/ files as part of the project, nor allows them to run without the unit_test_framework.
Al2Klimov
force-pushed
the
Al2Klimov-patch-15
branch
from
5cb857e to
5490dbe
Compare
Member
|
This is no longer required. See #10528. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with
-DICINGA2_WITH_TESTS=ON -DBUILD_TESTING=ONCLion (and likely not only it) doesn't recognize any test/ files as part of the project, nor allows them to run without the unit_test_framework.@yhabteab Again thank you for your help with fixing missing unit_test_framework on my WS.