-
Notifications
You must be signed in to change notification settings - Fork 0
Pull Request for the Docuquery Api #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start with uvicorn
… in production using tools like Datadog, Splunk, or the ELK stack.
…ization from module level to function level
benx421
requested changes
Nov 30, 2025
benx421
requested changes
Dec 1, 2025
Collaborator
benx421
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I responded to the open comments
- Move limiter from app/__init__.py to app/dependencies.py to avoid side effects and circular imports. - Create HealthService to encapsulate database connectivity checks. - Refactor app/api/health_check.py to use HealthService via dependency injection, removing direct DB session usage. - Update all relevant imports to point to app/dependencies.py.
benx421
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request covers all the implementation for the docuquery api. the goal of the project is an attempt to make an Internal RAG system with semantic caching. the RAG system gets the answer, only, from the documents (md in zip) uploaded to the /upload endpoint.