Split tests into separate files for Accessors, Mutators and Initializers

src/Accessor/FindAccessor.php

@@ -14,7 +14,7 @@ class FindAccessor extends Accessor
      *
      * @param Collection $collection
      * @param callable   $iterator
-     * @return Collection
+     * @return bool
      */
     public function __invoke($collection, $iterator)
     {

src/Accessor/ValueAccessor.php

@@ -5,6 +5,9 @@
 use Underscore\Accessor;
 use Underscore\Collection;
 
+/**
+ * @deprecated Use toArray() instead. Will be removed in later releases
+ */
 class ValueAccessor extends Accessor
 {
     /**

src/Collection.php

@@ -29,6 +29,7 @@ public function getIteratorReversed()
 
     /**
      * @return mixed
+     * @deprecated Use toArray() instead. Will be removed in later releases
      */
     public function value()
     {

tests/Accessor/AllAccessorTest.php

@@ -0,0 +1,40 @@
+<?php
+
+namespace Underscore\Test\Accessor;
+
+use Underscore\Accessor;
+use Underscore\Collection;
+
+class AllAccessorTest extends BaseAccessorTest
+{
+    /**
+     * @inheritDoc
+     */
+    protected function getInstance()
+    {
+        return new Accessor\AllAccessor();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getTestInvokeData()
+    {
+        $func = function ($value) {
+            return 3 <= strlen($value);
+        };
+        $ret = [];
+
+        $ret[] = [
+            true,
+            [new Collection($this->getDummy1()), $func],
+        ];
+
+        $ret[] = [
+            false,
+            [new Collection($this->getDummy2()), $func],
+        ];
+
+        return $ret;
+    }
+}

tests/Accessor/AnyAccessorTest.php

@@ -0,0 +1,40 @@
+<?php
+
+namespace Underscore\Test\Accessor;
+
+use Underscore\Accessor;
+use Underscore\Collection;
+
+class AnyAccessorTest extends BaseAccessorTest
+{
+    /**
+     * @inheritDoc
+     */
+    protected function getInstance()
+    {
+        return new Accessor\AnyAccessor();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getTestInvokeData()
+    {
+        $func = function ($value) {
+            return is_bool($value);
+        };
+        $ret = [];
+
+        $ret[] = [
+            false,
+            [new Collection($this->getDummy1()), $func],
+        ];
+
+        $ret[] = [
+            true,
+            [new Collection($this->getDummy2()), $func],
+        ];
+
+        return $ret;
+    }
+}

tests/Accessor/BaseAccessorTest.php

@@ -0,0 +1,91 @@
+<?php
+
+namespace Underscore\Test\Accessor;
+
+use Underscore\Accessor;
+
+abstract class BaseAccessorTest extends \PHPUnit_Framework_TestCase
+{
+    protected static function getDummy1()
+    {
+        $dummy = new \stdClass();
+        $dummy->name = 'dummy';
+        $dummy->foo = 'bar';
+        $dummy->baz = 'qux';
+
+        return $dummy;
+    }
+
+    /**
+     * @return object
+     */
+    protected static function getDummy2()
+    {
+        $dummy = self::getDummy1();
+        $dummy->false = false;
+        $dummy->null = null;
+        $dummy->zero = 0;
+
+        return $dummy;
+    }
+
+    protected static function getDummy3()
+    {
+        $dummy = [
+            'Angela' => [
+                'position' => 'dean',
+                'sex'      => 'female',
+            ],
+            'Bob'    => [
+                'position' => 'janitor',
+                'sex'      => 'male',
+            ],
+            'Mark'   => [
+                'position' => 'teacher',
+                'sex'      => 'male',
+                'tenured'  => true,
+            ],
+            'Wendy'  => [
+                'position' => 'teacher',
+                'sex'      => 'female',
+                'tenured'  => 1,
+            ],
+        ];
+
+        return $dummy;
+    }
+
+
+    /**
+     * @return object
+     */
+    protected static function getDummy4()
+    {
+        $dummy = self::getDummy2();
+        $dummy->false = false;
+        $dummy->null = null;
+        $dummy->zero = 0;
+        $dummy->one = 1;
+
+        return $dummy;
+    }
+    /**
+     * @return Accessor|callable
+     */
+    abstract protected function getInstance();
+
+    /**
+     * @return mixed[]
+     */
+    abstract protected function getTestInvokeData();
+
+    /**
+     * @param mixed $expected
+     * @param mixed $args
+     * @dataProvider getTestInvokeData
+     */
+    public function testInvoke($expected, $args)
+    {
+        $this->assertSame($expected, call_user_func_array($this->getInstance(), $args));
+    }
+}

tests/Accessor/ContainsAccessorTest.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace Underscore\Test\Accessor;
+
+use Underscore\Accessor;
+use Underscore\Collection;
+
+class ContainsAccessorTest extends BaseAccessorTest
+{
+    /**
+     * @inheritDoc
+     */
+    protected function getInstance()
+    {
+        return new Accessor\ContainsAccessor();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getTestInvokeData()
+    {
+        $ret = [];
+
+        $ret[] = [
+            true,
+            [new Collection($this->getDummy1()), 'bar'],
+        ];
+
+        $ret[] = [
+            false,
+            [new Collection($this->getDummy1()), 'baz'],
+        ];
+
+        return $ret;
+    }
+}

tests/Accessor/FindAccessorTest.php

@@ -0,0 +1,43 @@
+<?php
+
+namespace Underscore\Test\Accessor;
+
+use Underscore\Accessor;
+use Underscore\Collection;
+
+class FindAccessorTest extends BaseAccessorTest
+{
+    /**
+     * @inheritDoc
+     */
+    protected function getInstance()
+    {
+        return new Accessor\FindAccessor();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getTestInvokeData()
+    {
+        $func = function ($needle) {
+            return function ($value) use ($needle) {
+                return $value === $needle;
+            };
+        };
+
+        $ret = [];
+
+        $ret[] = [
+            false,
+            [new Collection($this->getDummy1()), $func('foo')],
+        ];
+
+        $ret[] = [
+            true,
+            [new Collection($this->getDummy1()), $func('bar')],
+        ];
+
+        return $ret;
+    }
+}

tests/Accessor/HasAccessorTest.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace Underscore\Test\Accessor;
+
+use Underscore\Accessor;
+use Underscore\Collection;
+
+class HasAccessorTest extends BaseAccessorTest
+{
+    /**
+     * @inheritDoc
+     */
+    protected function getInstance()
+    {
+        return new Accessor\HasAccessor();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getTestInvokeData()
+    {
+        $ret = [];
+
+        $ret[] = [
+            true,
+            [new Collection($this->getDummy1()), 'foo'],
+        ];
+
+        $ret[] = [
+            false,
+            [new Collection($this->getDummy1()), 'bar'],
+        ];
+
+        return $ret;
+    }
+}

tests/Accessor/MaxAccessorTest.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace Underscore\Test\Accessor;
+
+use Underscore\Accessor;
+use Underscore\Collection;
+
+class MaxAccessorTest extends BaseAccessorTest
+{
+    /**
+     * @inheritDoc
+     */
+    protected function getInstance()
+    {
+        return new Accessor\MaxAccessor();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getTestInvokeData()
+    {
+        $ret = [];
+
+        $ret[] = [
+            2,
+            [new Collection([0, 1, 2])],
+        ];
+
+        $ret[] = [
+            0,
+            [new Collection([0, false, 'foo'])],
+        ];
+
+        return $ret;
+    }
+}

tests/Accessor/MinAccessorTest.php

@@ -0,0 +1,37 @@
+<?php
+
+namespace Underscore\Test\Accessor;
+
+use Underscore\Accessor;
+use Underscore\Collection;
+
+class MinAccessorTest extends BaseAccessorTest
+{
+    /**
+     * @inheritDoc
+     */
+    protected function getInstance()
+    {
+        return new Accessor\MinAccessor();
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function getTestInvokeData()
+    {
+        $ret = [];
+
+        $ret[] = [
+            0,
+            [new Collection([0, 1, 2])],
+        ];
+
+        $ret[] = [
+            0,
+            [new Collection([0, false, 'foo'])],
+        ];
+
+        return $ret;
+    }
+}