Conversation
html/popup.html
Outdated
| </div> | ||
| <div> | ||
| <i>Tips: You can hide the player with Alt+Maj+T</i> | ||
| <i>Tips: You can hide the player with Ctrl+Shift+Z</i> |
There was a problem hiding this comment.
Have you checked if it's not bind to anything already ?
There was a problem hiding this comment.
Also I kinda liked the usage of T like toogle.
If we change, please also change the readme :)
There was a problem hiding this comment.
Yes, I already checked, and I changed the readme as well. I had to change because the "Alt" key didn't seem to be triggered at all. But I'm open for any change.
There was a problem hiding this comment.
CTRL+Shift+Z looks too much like the redo command. Are you sure it's not working with the old binds ?
There was a problem hiding this comment.
Agreed. Totaly sure the old binding does not work. I suspect the problem tu be the "Alt" key. How about "Ctrl+Shift+Space" ?
There was a problem hiding this comment.
@ImFlog Have you had time to take a look at it?
| </div> | ||
| <div> | ||
| <i>Tips: You can hide the player with Alt+Maj+T</i> | ||
| <i>Tips: You can hide the player with Ctrl+Shift+Space</i> |
There was a problem hiding this comment.
From https://developer.chrome.com/apps/commands : Please note that on Mac 'Ctrl' is automatically converted to 'Command'. If you want 'Ctrl' instead, please specify 'MacCtrl' under "mac". Specifying 'MacCtrl' under "default" will cause the extension to be uninstallable.
We can't use this as CMD + Space triggers the spotlight search on macOs :)
There was a problem hiding this comment.
Fine, what do we use, then?
There was a problem hiding this comment.
- Please note that on Mac 'Ctrl' is automatically converted to 'Command'. If you want 'Ctrl' instead, please specify 'MacCtrl' under "mac". Specifying 'MacCtrl' under "default" will cause the extension to be uninstallable.
We could use ctrl + Shift + space for default and MaCtrl + Shift + Space for mac ?
What bothers me is that there is no easy way to remember this shortcut :(
There was a problem hiding this comment.
@ImFlog you're right, let's discuss about it
2 participants
No description provided.