Skip to content

feat: make setting timeout values more visible and meaningful for users #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karel-rehor merged 20 commits into from
Sep 19, 2025
Merged

feat: make setting timeout values more visible and meaningful for users #158

karel-rehor merged 20 commits into from
Sep 19, 2025

Conversation

@karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Sep 4, 2025 •
edited
Loading

Proposed Changes

  • Adds and exposes new property timeout in WriteOptions
  • Adds new kw handlers to InfluxDBClient3.__init__ for query_timeout and write_timeout
  • Adds and exposes new property timeout in QueryApiOptions
  • Ensures these values are updated and used.
  • Tests to cover these changes and some up-to-the-present areas not covered in previous tests.
  • Some minor refactoring with better type enforcement in a few places.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor
docs: update api doc regarding types used for client_options.
b22870b
@karel-rehor
feat: (WIP) - placeholder. Adds timeout property to WriteOptions and …
fd03020 
…proposed tests
@karel-rehor
chore: (WIP) starting timeout improvements. Remove unused import.
14bedd6
@karel-rehor
feat: (WIP) timeouts - adds tests for write API timeout.
3a05af6
@karel-rehor
feat: (WIP) add user definable query timeout
e8f7166
@karel-rehor
tests: shorten test timeout
ff136e1
@karel-rehor
chore: clean up flake
7b2b906
@karel-rehor
chore: cleanup flake in tests
a23ccf5
@karel-rehor
tests: shorten timeout in test
8229057
@karel-rehor
chore: minor refactoring. Sync timeout types in __init__. Extra tests.
adc3d0b
@karel-rehor
chore: skip flaky integration test.
c7cf499
@karel-rehor
chore: more informative skip message
a0ff36e
@karel-rehor
tests: test timeout envars
cdd6e1e
@karel-rehor
chore: using _request_timeout write kwargs in write calls.
d584301
@karel-rehor
chore: (WIP - 2 failing test) use kwargs in batching mode.
453e18c
@karel-rehor
chore: fix broken tests and flake
51430eb
@karel-rehor
docs: adds timeouts.py example
d047f39
@karel-rehor
chore: fix flake and assertion for integration test.
6986d64
@karel-rehor
docs: update CHANGELOG.md
22c9b8e
@karel-rehor karel-rehor marked this pull request as ready for review September 11, 2025 09:36
jansimonb
jansimonb approved these changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@jansimonb jansimonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 👍 Special thanks for the code+docs improvements and the throughout testing.

@karel-rehor karel-rehor merged commit 51c9a37 into main Sep 19, 2025
12 checks passed
@karel-rehor karel-rehor deleted the feat/timeouts branch September 19, 2025 08:39
lebuni pushed a commit to lebuni/influxdb3-python that referenced this pull request Nov 30, 2025
fix: write_api TypeError in kwargs
7f20d81 
PR InfluxCommunity#158 introduced a bug writing dataframes.
Filtering now the kwargs before forwarding them to lower levels
@lebuni lebuni mentioned this pull request Nov 30, 2025
Merged
6 tasks
lebuni pushed a commit to lebuni/influxdb3-python that referenced this pull request Nov 30, 2025
fix: write_api TypeError in kwargs
8e4dcd8 
PR InfluxCommunity#158 introduced a bug writing dataframes.
Filtering now the kwargs before forwarding them to lower levels
lebuni pushed a commit to lebuni/influxdb3-python that referenced this pull request Dec 2, 2025
fix: write_api TypeError in kwargs
bae3905 
PR InfluxCommunity#158 introduced a bug writing dataframes.
Filtering now the kwargs before forwarding them to lower levels
bednar pushed a commit that referenced this pull request Dec 2, 2025
@lebuni
feat: Add Dedicated DataFrame Methods for Writing and Querying (#177)
fb7b3f9 
* feat: add dedicated functions for dataframes

Dataframes were handled before by the general write command, but not documented and not typechecked.
Therefore implemented separate functions for writing and querying dataframes.

* fix: write_api TypeError in kwargs

PR #158 introduced a bug writing dataframes.
Filtering now the kwargs before forwarding them to lower levels

---------

Co-authored-by: Adrian Immer <a.immer@munichelectrification.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansimonb jansimonb jansimonb approved these changes

@NguyenHoangSon96 NguyenHoangSon96 Awaiting requested review from NguyenHoangSon96

@bednar bednar Awaiting requested review from bednar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karel-rehor @jansimonb