Skip to content

Use types to make sure value objects are correct#13

Merged
Baptouuuu merged 23 commits intodevelopfrom
closed-value-objects
May 8, 2025
Merged

Use types to make sure value objects are correct#13
Baptouuuu merged 23 commits intodevelopfrom
closed-value-objects

Conversation

@Baptouuuu
Copy link
Member

While closing down value objects it appeared LoadAverage wasn't safe. The possible error is now expressed as a type by Server::loadAverage() now returning an Attempt.

@Baptouuuu Baptouuuu self-assigned this May 8, 2025
@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (560b787) to head (d0f09ed).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #13   +/-   ##
==========================================
  Coverage      99.93%   99.93%           
- Complexity       259      261    +2     
==========================================
  Files             55       55           
  Lines           1457     1516   +59     
==========================================
+ Hits            1456     1515   +59     
  Misses             1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Baptouuuu Baptouuuu merged commit 3c49fe5 into develop May 8, 2025
92 of 95 checks passed
@Baptouuuu Baptouuuu deleted the closed-value-objects branch May 8, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant