Feat/rapport qualite #417
Open
Feat/rapport qualite #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/!\ one test for concept is KO => to evaluate
to fix : duplicate code_list
lack type ORGANIZATION rubric
…to feat/rapport-qualite
added 5 commits
January 12, 2026 15:56
FBibonne
reviewed
Jan 15, 2026
Member
FBibonne
left a comment
FBibonne
left a comment
There was a problem hiding this comment.
- dans le code actuel, il faut revoir la méthode fr.insee.rmes.magma.diffusion.utils.RapportQualiteDTO#transformDTOenRapportQualite : a minima l'isoler dans un service et écrire un test.
- Dans TestContainerTest : pour pourquoi le
container.stop()est commenté ? - monter la version de testcontainers en 1.21.4
- ConceptDTO : supprimer la méthode getNearbyConceptList et limport de l'annotation @NotNull
...est/java/fr/insee/rmes/magma/diffusion/api/testcontainers/queries/OperationsQueriesTest.java
Show resolved
Hide resolved
magma-diffusion-impl/src/main/java/fr/insee/rmes/magma/diffusion/utils/RapportQualiteDTO.java
Show resolved
Hide resolved
magma-diffusion-impl/src/main/java/fr/insee/rmes/magma/diffusion/utils/RapportQualiteDTO.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| return ResponseEntity.ok() | ||
| .contentType(contentType) |
Member
There was a problem hiding this comment.
ce n'est pas utile de renseigner le content type, il est généré automatiquement par Spring lors de la sérialisation de l'objet retourné
Member
There was a problem hiding this comment.
Il faut ajouter la dépendance
<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-xml</artifactId>
</dependency>Si le header accept est correct, le content type est déterminé automatiquement et la sérialisation se fait correctement
magma-diffusion-impl/src/main/java/fr/insee/rmes/magma/diffusion/utils/EndpointsUtils.java
Outdated
Show resolved
Hide resolved
magma-diffusion-impl/src/main/java/fr/insee/rmes/magma/diffusion/utils/EndpointsUtils.java
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,53 @@ | |||
| package fr.insee.rmes.magma.diffusion.utils; | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.