RecursiveGaussian filters: Use std::array instead of C-array for m_SmoothingFilters, use std::generate and range-based for
#5731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increased the consistency of `m_SmoothingFilters` declarations of recursive Gaussian filters. Following pull request InsightSoftwareConsortium#5730 commit 529d8f9 and a837ee5
Increased the consistency in the way `m_SmoothingFilters` are filled, in the constructors of recursive Gaussian filters. Following pull request InsightSoftwareConsortium#5730 commit 529d8f9 and a837ee5
github-actions
bot
added
the
area:Filtering
hjmjohnson
approved these changes
Jan 16, 2026
N-Dekker
commented
Jan 16, 2026
Modules/Filtering/ImageFeature/include/itkHessianRecursiveGaussianImageFilter.hxx
Outdated
Show resolved
Hide resolved
N-Dekker
force-pushed
the
m_SmoothingFilters-std-array
branch
from
4488e21 to
6b1884c
Compare
N-Dekker
changed the title
for
Expressed explicitly that each filter of m_SmoothingFilters is processed, by SetSigma, SetNormalizeAcrossScale, SetNumberOfWorkUnits, and `progress->RegisterInternalFilter`.
N-Dekker
force-pushed
the
m_SmoothingFilters-std-array
branch
from
6b1884c to
309a08f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to improve the consistency between the implementations of the five recursive Gaussian filters.
std::arrayfor m_SmoothingFilters, remove GaussianFiltersArray alias #5730