memory: correctly merge segments when the new block prepends the old#17
Merged
benedekkupper merged 1 commit intomainfrom Feb 10, 2026
Merged
memory: correctly merge segments when the new block prepends the old#17benedekkupper merged 1 commit intomainfrom
benedekkupper merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes segment merging in RawMemory.TryAddSegment when the incoming segment should merge contiguously with an existing segment (specifically the “prepend” case from Issue #15).
Changes:
- Replace
Segment.TryAppendwithSegment.TryMergeto support merging in both directions (prepend/append). - Update
RawMemory.TryAddSegmentto useTryMergewhen attempting to coalesce contiguous segments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| DeviceProgramming/Memory/Segment.cs | Reworks contiguous-segment combination logic into TryMerge. |
| DeviceProgramming/Memory/RawMemory.cs | Switches add-path merge attempt to call TryMerge on existing segments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
benedekkupper
force-pushed
the
memory-merge
branch
from
ca538bf to
b938840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15