chore(build): remove max-backjumps constraint from cabal configuration#1006
Open
chore(build): remove max-backjumps constraint from cabal configuration#1006
Conversation
209c895 to
e198531
Compare
carbolymer
requested changes
Nov 17, 2025
Contributor
carbolymer
left a comment
There was a problem hiding this comment.
This branch needs to be rebased onto latest master first, because in its current state cardano-rpc is still disabled.
The max-backjumps workaround was needed for grpc-related dependency tree.
|
This PR is stale because it has been open 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This PR removes the
max-backjumps: 50000constraint from the cabal.project configuration. This constraint was originally added to help cabal's constraint solver handle complex dependency resolution, but it has been causing slower build plan preparation times. Recent improvements to the dependency structure and cabal solver mean this workaround is no longer needed.Additionally, this PR includes several housekeeping updates:
Cardano.Api.HasTypeProxymodule from the main APIcaseBabbageOnlyOrConwayEraOnwardsfor era handlingInvestigation for #909
How to trust this PR
The main change removes a build configuration that was explicitly marked as temporary in the code comments. To verify:
Build the project without the max-backjumps constraint:
Verify that cabal can still solve dependencies correctly:
Compare build plan preparation time before and after the change - it should be noticeably faster without the constraint.
The documentation and API changes are straightforward additions that don't modify existing functionality.
Checklist