Add golden test for hash computation of serialised CBOR script read from file (either binary or text file)#1090
Open
koslambrou wants to merge 1 commit intomasterfrom
Open
Conversation
…rom file (either binary or text file)
fe98a36 to
e75a0ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Given a serialised Plutus script as CBOR and saved and to a file, there are multiple ways to read it in order to compute the hash. We realised that some ways are correct, and other incorrect ("incorrect" in the sense that the code compiles and runs with no runtime errors, but gives a different script hash).
Therefore, this PR provides some golden tests that serve as documentation on the correct way to achieve this goal.
Checklist