Open
Conversation
newhoggy
requested review from
CarlosLopezDeLara,
Jimbo4350,
carbolymer,
dcoutts,
disassembler,
erikd,
kevinhammond and
palas
as code owners
carbolymer
reviewed
Apr 15, 2025
| @@ -22,5 +23,8 @@ class Typeable t => HasTypeProxy t where | |||
|
|
|||
| proxyToAsType :: Proxy t -> AsType t | |||
|
|
|||
| asTypeFromValue :: HasTypeProxy t => t -> AsType t | |||
| asTypeFromValue _ = proxyToAsType Proxy | |||
|
|
|||
Contributor
There was a problem hiding this comment.
This would be useful too:
Suggested change
| asType :: HasTypeProxy t => AsType t | |
| asType = proxyToAsType Proxy |
carbolymer
reviewed
Apr 15, 2025
| @@ -6,6 +6,7 @@ module Cardano.Api.Internal.HasTypeProxy | |||
| ( HasTypeProxy (AsType, proxyToAsType) | |||
| , Proxy (..) | |||
| , FromSomeType (..) | |||
| , asTypeFromValue | |||
Contributor
There was a problem hiding this comment.
don't you have to export it from Cardano.Api as well?
carbolymer
approved these changes
Apr 15, 2025
Jimbo4350
approved these changes
Apr 15, 2025
|
This PR is stale because it has been open 45 days with no activity. |
|
This PR is stale because it has been open 45 days with no activity. |
newhoggy
force-pushed
the
newhoggy/new-asTypeFromValue-function
branch
2 times, most recently
from
e8bcfe9 to
1db629a
Compare
newhoggy
force-pushed
the
newhoggy/new-asTypeFromValue-function
branch
from
1db629a to
7abe88f
Compare
|
This PR is stale because it has been open 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Context
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist