Skip to content

Move Arbitrary instances from cardano-ledger to cardano-binary#618

Draft
neilmayhew wants to merge 2 commits intomasterfrom
nm/more-arbitrary-instances
Draft

Move Arbitrary instances from cardano-ledger to cardano-binary#618
neilmayhew wants to merge 2 commits intomasterfrom
nm/more-arbitrary-instances

Conversation

@neilmayhew
Copy link
Contributor

@neilmayhew neilmayhew commented Feb 4, 2026

Description

The instances are for:

  • ByteArray, SlicedByteArray and Term from cborg

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Self-reviewed the diff

@neilmayhew neilmayhew requested review from a team and lehins as code owners February 4, 2026 03:50
@neilmayhew neilmayhew requested a review from f-f February 4, 2026 03:50
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not move these instances at this point and wait till we have a necessary breaking change to cardano-binary

@neilmayhew neilmayhew force-pushed the nm/more-arbitrary-instances branch from 2a3ce44 to 27c5b7e Compare February 4, 2026 14:54
@neilmayhew neilmayhew marked this pull request as draft February 4, 2026 14:56
@neilmayhew neilmayhew force-pushed the nm/more-arbitrary-instances branch from 27c5b7e to a74db21 Compare February 4, 2026 15:00
@neilmayhew neilmayhew force-pushed the nm/more-arbitrary-instances branch from a74db21 to 2f6ef54 Compare February 7, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants