Test-suite coverage for type-class laws of core types#785
Open
recursion-ninja wants to merge 1 commit intomainfrom
Open
Test-suite coverage for type-class laws of core types#785recursion-ninja wants to merge 1 commit intomainfrom
recursion-ninja wants to merge 1 commit intomainfrom
Conversation
recursion-ninja
requested review from
dcoutts,
jorisdral,
mheinzel and
wenkokke
as code owners
recursion-ninja
force-pushed
the
recursion-ninja/code-coverage-type-class-laws
branch
from
11dba78 to
3c71853
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
QuickCheck-based property tests for the type-class laws of all data-types exported from theDatabase.LSMtreemodule. This PR is motivated by the code coverage discussion from #662. Many of the data-types have non-trivial instances of type-classes and it is prudent to provide assurance that the data-types have lawful instance.Note: Exception data-types were excluded from coverage as they tend to only have a
Showinstance.Here is the coverage improvement of the most impacted modules.
Database.LSMTreeDatabase.LSMTree.Internal.ConfigDatabase.LSMTree.Internal.PathsDatabase.LSMTree.Internal.RangeDatabase.LSMTree.Internal.SnapshotDatabase.LSMTree.Internal.Unsafe