Skip to content

Conversation

@ngarnsworthy
Copy link
Collaborator

Before issuing a pull request:

  • Ensure all constants are in the Constants class
  • Update the backup OpMode if needed
  • Update README.md

Copilot AI review requested due to automatic review settings November 12, 2025 01:12
@ngarnsworthy ngarnsworthy linked an issue Nov 12, 2025 that may be closed by this pull request
5 tasks
Copy link

@BdogAsix BdogAsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a

@ngarnsworthy ngarnsworthy merged commit b002622 into master Nov 12, 2025
4 of 5 checks passed
@ngarnsworthy ngarnsworthy deleted the 3-learn-code-chase branch November 12, 2025 01:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new learning OpMode for mecanum drive control, created by Chase. It follows the established pattern of other learning OpModes in the team's repository, using the Constants class for motor names and implementing basic field-centric mecanum drive kinematics.

  • Uses Constants class for motor name configuration
  • Implements standard mecanum drive kinematics with joystick control
  • Sets motor directions for proper mecanum drive operation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


@Override
public void loop() {
double y = gamepad1.left_stick_y;
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Y-axis should be negated. In FTC, the gamepad's left_stick_y returns negative values when pushed forward. Other learning OpModes in this directory (BrodysFIRSTOpMode.java and NicksFIRSTJavaOpMode.java) use -gamepad1.left_stick_y to ensure pushing the stick forward makes the robot move forward. Without negation, the robot will move backward when the stick is pushed forward.

Suggested change
double y = gamepad1.left_stick_y;
double y = -gamepad1.left_stick_y;

Copilot uses AI. Check for mistakes.

import org.firstinspires.ftc.teamcode.Constants;

@TeleOp(name="Chase's OpMode", group = "Example OpMode")
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing @disabled annotation. All other learning OpModes (BrodysFIRSTOpMode.java and NicksFIRSTJavaOpMode.java) include the @disabled annotation to prevent accidental selection during competition. Add @Disabled on line 11 before the class declaration for consistency with the team's learning OpMode pattern.

Suggested change
@TeleOp(name="Chase's OpMode", group = "Example OpMode")
@TeleOp(name="Chase's OpMode", group = "Example OpMode")
@com.qualcomm.robotcore.eventloop.opmode.Disabled

Copilot uses AI. Check for mistakes.

telemetry.addData("Status", "Running");
telemetry.update();
}
Copy link

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Missing stop() method override. For consistency with other learning OpModes in this directory, consider adding a stop() method that updates telemetry status to 'Stopped', similar to BrodysFIRSTOpMode.java and NicksFIRSTJavaOpMode.java. This helps students understand the complete OpMode lifecycle.

Suggested change
}
}
@Override
public void stop() {
telemetry.addData("Status", "Stopped");
telemetry.update();
}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Learn code - Chase

3 participants