Convoy/latest #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typ-o manully
Expose registration failure event
…otif is available
Typ-o regsitered
Fix improper reference in readme.
…ion on old devices
RN 0.40 support
…thout remove it from bridgeQueue, cause triggering same action multiple times.
[GCM>FCM] Update with latest change from wix repository
# Conflicts: # README.md # RNNotifications/RNNotifications.h # RNNotifications/RNNotifications.m # android/build.gradle # android/src/main/java/com/wix/reactnativenotifications/RNNotificationsPackage.java # android/src/main/java/com/wix/reactnativenotifications/core/NotificationIntentAdapter.java # android/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotification.java # package.json
[GCM>FCM] Bring in FCM support from the wix repository
Fix some build errors when bring this change into the mobile app
…weren't sent to JS
…ntNotSentToJS add RNNotificationsNativeCallback so native can track PN events that weren't sent to JS
…o resolve build warnings
…ild-warnings Bump gradle build tools and move to implementation and api keywords t…
Jonathan/say when
bump version
…o the UI thread. This is required due to the changes around JobIntentService required for scheduling work on android O and above. In this mode the FcmToken methods can be executed on threads other than the UI thread. This flow can cause the main ReactNativeInstance to be null, and thus require a creation call to execute. Because this call must be executed on a main thread we get crashes. Solution is to always post this action to the main thread as a protection against background execution of the ReactNativeInstance.createReactNativeInstanceManager call. .
…for_fcm_token Updates FcmToken.sendTokenToJS to always post a runnable to the UI thread.
Use BigText style on Android push notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a null check to prevent crashing if rawData is null