fixed isValid function - regexp not being used correctly #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Added comments, factored the validity test to '.slice().pop()', replaced last var with let. |
Owner
Author
|
Mistakenly closed. |
reneemeyer
suggested changes
Aug 3, 2017
reneemeyer
left a comment
reneemeyer
left a comment
There was a problem hiding this comment.
Nice job, just a couple of changes to make before you merge! I like the code plan in here.
| // of the disks are initially placed on peg 'a' and must be placed in order | ||
| // on either peg 'b' or 'c' to solve the puzzle. | ||
|
|
||
| let stacks = { |
| return true; | ||
| } | ||
| return win; | ||
| return false; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved upon the original Towers of Hanoi that was uploaded directly to the master. Added isValid function to ensure input is valid. Initially used regexp comparison, but needed to change function to confirm validity through simple string comparisons.