add stddev file for sqrt(B) randomization #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlyaeva
reviewed
Aug 25, 2023
Contributor
shlyaeva
left a comment
shlyaeva
left a comment
There was a problem hiding this comment.
What changed in the file?
Author
|
Created a new stddev file to avoid cases where xb < stddev. Close to that condition the approximation becomes less accurate and creates negative concentrations. This was the case with the current stddev files which was from fields from a different date and were then creating this condition in the higher levels. |
xian22
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
data PR for https://github.com/JCSDA-internal/fv3-jedi/pull/1004
Issue(s) addressed
https://github.com/JCSDA-internal/fv3-jedi/issues/991
Dependencies
List the other PRs that this PR is dependent on:
Impact
Expected impact on downstream repositories:
Checklist