Add Music and SFX volume adjustment toggles#192
Open
Kriix08 wants to merge 2 commits intoJSsixtyfour:masterfrom
Open
Add Music and SFX volume adjustment toggles#192Kriix08 wants to merge 2 commits intoJSsixtyfour:masterfrom
Kriix08 wants to merge 2 commits intoJSsixtyfour:masterfrom
Conversation
Author
|
default values for volume when playing on PJ64KSE can show up as 1, for some reason, so gonna try looking into that |
I couldn't actually reproduce the issue more than once, so I'll just hope this does fix it :')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes from 1 to 10
Runs a volume change upon pressing start on title screen (otherwise master volumes apply a lot later and it would sound jarring), Also updates volume when pressing A on the toggles or when exiting the Settings super menu