ci: Use reusable workflow for integration tests #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baptistegrimaud
force-pushed
the
ci-use-reusable-workflow-for-integration-tests
branch
from
44892ee to
87c78ee
Compare
GauBen
force-pushed
the
ci-use-reusable-workflow-for-integration-tests
branch
from
c70e82f to
32b77cf
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors GitHub Actions workflows to use reusable workflow patterns, consolidating CI logic into centralized workflow templates. This reduces duplication and improves maintainability by delegating complex job definitions to shared workflows.
Key changes:
- Replaced inline job definitions with calls to reusable workflows from
jahia-modules-action - Added a lint script for TypeScript files in the tests package
- Enabled video recording in Cypress configuration
Reviewed Changes
Copilot reviewed 4 out of 74 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/on-code-change.yml |
Replaced multiple inline jobs (static-analysis, build, sonar-analysis, integration-tests-standalone) with a single call to reusable workflow |
.github/workflows/manual-run.yml |
Simplified integration-tests job by delegating to reusable workflow |
tests/package.json |
Added lint script for ESLint validation |
tests/cypress.config.ts |
Enabled video recording for test runs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
baptistegrimaud
force-pushed
the
ci-use-reusable-workflow-for-integration-tests
branch
from
47b5abb to
3acfa15
Compare
baptistegrimaud
changed the title
baptistegrimaud
force-pushed
the
ci-use-reusable-workflow-for-integration-tests
branch
from
3acfa15 to
c2109eb
Compare
GauBen
approved these changes
Nov 14, 2025
Fgerthoffert
approved these changes
Nov 14, 2025
Member
Fgerthoffert
left a comment
Fgerthoffert
left a comment
There was a problem hiding this comment.
At a first glance this looks good, but can you make sure the nightlys and manual-run runs before merging (i.e. manually triggering the nightly on the branch)
Contributor
Author
|
Workflow executions against this branch: |
baptistegrimaud
deleted the
ci-use-reusable-workflow-for-integration-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the reusable workflow when running the integration tests in the different workflows.
For the nightly tests, add an entry in the matrix to run against the latest Jahia release in addition to the latest Jahia snapshot.
Also, move the Cypress test module from
javascript-modules-engine/tests/totests/to align with the convention we use in the rest of our projects.Tip
Documentation to guide the reviews: How to do a code review