Skip to content

Conversation

@GauBen
Copy link
Member

@GauBen GauBen commented Nov 17, 2025

Description

Found a few files in the test module that we never imported

Checklist

Source code

  • I've shared and documented any breaking change
  • I've reviewed and updated the jahia-depends

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Tip

Documentation to guide the reviews: How to do a code review

@GauBen GauBen requested a review from a team as a code owner November 17, 2025 10:28
Copilot AI review requested due to automatic review settings November 17, 2025 10:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused code files from the test module that were never imported elsewhere in the codebase. The cleanup involves removing three utility files related to navigation functionality.

Key Changes:

  • Removed unused hooks and helper functions for page navigation
  • Eliminated dead code from the test module

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
jahia-test-module/src/hooks/usePageAncestors.ts Removed unused hook for querying page ancestors via GraphQL
jahia-test-module/src/hooks/useBaseNode.ts Removed unused hook for determining navigation base node
jahia-test-module/src/helpers/menu.ts Removed unused helper for building navigation menu structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GauBen GauBen added the 🗒️ no-changelog No release notes or changelog entry should be added for this PR or Issue label Nov 17, 2025
@GauBen GauBen enabled auto-merge (squash) November 17, 2025 10:37
@GauBen GauBen merged commit 21d43a9 into main Nov 17, 2025
15 checks passed
@GauBen GauBen deleted the refactor/remove-dead-code branch November 17, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗒️ no-changelog No release notes or changelog entry should be added for this PR or Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants