This repository was archived by the owner on Sep 11, 2023. It is now read-only.
Open
Conversation
Owner
|
Without a detailed description, it's hard to understand what you're trying to acomplish. The use of the delayed event queue is cool, just never bothered to deal with it since the event was introduced way after bagnon was coded. However, there are a lot of obvious issues with these changes. Some I found:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge cleans up the bag update handling to be more streamlined and easier to understand and also applies the the collecting of BAG_UPDATE events to the bag class.