Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you very much for your work. However, I encountered an error when running your code. Upon investigation, I found that the issue might be related to the following line:
Model-Editing-Hurt/easyeditor/models/rome/rome_main.py
Line 33 in 8f8d4dc
The function does not have a return statement, which causes the return value of the following line of code to be None, leading to issues in subsequent calculations:
Model-Editing-Hurt/easyeditor/models/rome/rome_main.py
Line 79 in 8f8d4dc
Therefore, I added a return statement in set_min_to_zero function, and after preliminary testing, the subsequent execution works correctly.