Skip to content

Conversation

@Gobukgol
Copy link

@Gobukgol Gobukgol commented Sep 2, 2022

No description provided.

@Gobukgol Gobukgol self-assigned this Sep 2, 2022
Copy link

@jyami-kim jyami-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keepGoing 이부분이 좀 잘 이해가안가네 ㅠㅠ

import org.springframework.context.annotation.Import

@Configuration
class JobManagerConfig {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 BomConfig랑 합쳐도 괜찮을 거 같아

}

private fun updateJob() {
while (keepGoing) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이조건문 탈출하려면 어떻게 해야하는거야?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 스프링이 종료될 때 SmartLifeCycle 구현한 클래스의 stop 메소드 호출하면서 while 문 탈출 할 수 있도록 돌아가는걸로 알고있어!

Copy link
Member

@pci2676 pci2676 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 ScheduledTaskRegistrar참조해서 스레드풀이랑 스케쥴 등록 개선할 수 있을것 같아
크론을 어떻게 사용하는지 트리거를 어떻게 사용하는지 구현체가 이해하기 쉽게 작성되어있는것 같아


class TaskManager(
private val jobManager: JobManager,
private val jobCollection: JobCollection,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 잡 매니저 통해서 사용하면 이상한가?????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants