Fix getting machine name when running on device

[Eeems]

file.read() is already a string and not a bytes object, so you can't decode it.

Summary by CodeRabbit

• Refactor
  • Streamlined device initialization by simplifying the configuration file reading process. The update maintains existing error handling and fallback behavior while improving internal efficiency.

[coderabbitai]

Walkthrough

The change updates how the machine file at /sys/devices/soc0/machine is processed in the DeviceManager's initialization. The code now reads the file content directly and strips the newline without performing an explicit UTF-8 decoding. Error handling remains unchanged, with a fallback value assigned if the file is not available.

Changes

File	Summary of Changes
codexctl/device.py	Removed the .decode("utf-8") step when reading /sys/devices/soc0/machine in DeviceManager.__init__, reading directly as a string instead.

Sequence Diagram(s)

sequenceDiagram
    participant DM as DeviceManager.__init__
    participant FS as File System
    DM->>FS: Open '/sys/devices/soc0/machine'
    alt File exists
        FS-->>DM: Return file contents (string)
        DM->>DM: Strip newline and assign to machine_contents
    else File missing
        FS-->>DM: Raise FileNotFoundError
        DM->>DM: Assign fallback value "tests"
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c07b7d5 and 9523e56.

📒 Files selected for processing (1)

• codexctl/device.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Build for macos-latest
• GitHub Check: Build for windows-latest
• GitHub Check: Build for ubuntu-latest
• GitHub Check: Build for remarkable

🔇 Additional comments (1)

codexctl/device.py (1)

51-52: Fixed file reading when running locally.

This change correctly removes the unnecessary UTF-8 decoding step when reading the machine file locally. When using Python's standard open() function without specifying a mode, it opens the file in text mode and automatically handles the decoding. The previous implementation was likely causing an error by trying to decode an already-decoded string.

Note that the remote case (line 48) correctly keeps the .decode("utf-8") call since Paramiko's SFTP file reading returns bytes.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.