Fixed LLVM search. #36
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK it turns out LLVM's LLVMConfigVersion.cmake seems to not support range based searches. This PR gets around this by finding any available LLVM and then just comparing the major version.
The problem: suppose we want to find LLVM version X.Y.Z or more recent and we issue
find_package(LLVM X.Y.Z). We have LLVM version P.Q.R on the CMAKE prefix Path.The find_package() will only succeed if: X=P, Y=Z and R>=Z. It will not succeed for a range or a minor version difference. This is strict and it cannot acommodate a change going e.g. to the top of the release-20.x branch when asking for version 20.
The workaround here is to just ask to find any LLVM and check the major number post-facto:
find_package(LLVM CONFIG REQUIRED) # Generic find
if( ${LLVM_VERSION_MAJOR} EQUAL ... ) # We can process just major version equality