GH-245: Fix jelly-text serialization in AoT builds #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add regression test
Member
Author
|
The bug is one thing, but another is that we didn't catch even though we did have a test for it. There is some bash shenanigans going on with set -e, see: http://mywiki.wooledge.org/BashFAQ/105 I'm replacing this with explicit error handling, this should help... |
Karolina-Bogacka
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #245
The bug was caused by Google's protobuf implementation needlessly spamming reflection... for a branch of code that we don't even use. I've disabled it with a Graal substitution.
See also my note on testing below.