Skip to content

Conversation

@csiyang
Copy link
Contributor

@csiyang csiyang commented Jan 5, 2026

Feat

  • Removes slider for desktop editor
  • Journey flow takes up full width, content and settings appears in a drawer
  • rewire dispatch actions

To Do

  • Clicking on some of the empty spaces does not close the dialog
  • Check different screen sizes
  • Tidy up code
  • Remove unnecessary code
  • Refactor to simplify parts
  • Have a common styled component for settings drawer
  • Fix mobile
  • still use slider
  • some actions in editor provider has changed, need to add some dispatches to maintain current behaviour
  • Update Tests

To Consider

  • Change journey map origin location
  • share components between mobile and desktop (currently just duplicated all the components in slider)

@csiyang csiyang self-assigned this Jan 5, 2026
@linear
Copy link

linear bot commented Jan 5, 2026

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2026

Important

Review skipped

Too many files!

149 files out of 299 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch siyangcao/nes-308-condense-journey-map-and-card-editor-on-one-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

Fails
🚫 Please request a reviewer for this PR.
Warnings
⚠️ ❗ Big PR (103124 changes)

(change count - 103124): Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

Generated by 🚫 dangerJS against c794ed0

@nx-cloud
Copy link

nx-cloud bot commented Jan 5, 2026

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit c794ed0

Command Status Duration Result
nx run journeys-admin-e2e:e2e ❌ Failed 6m 27s View ↗
nx run journeys-e2e:e2e ✅ Succeeded 22s View ↗
nx run watch-e2e:e2e ✅ Succeeded 35s View ↗
nx run resources-e2e:e2e ✅ Succeeded 29s View ↗
nx run videos-admin-e2e:e2e ✅ Succeeded 4s View ↗
nx run-many --target=vercel-alias --projects=jo... ✅ Succeeded 2s View ↗
nx run-many --target=upload-sourcemaps --projec... ✅ Succeeded 12s View ↗
nx run-many --target=deploy --projects=journeys... ✅ Succeeded 2m 54s View ↗
Additional runs (12) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2026-01-05 22:22:55 UTC

@github-actions github-actions bot temporarily deployed to Preview - journeys January 5, 2026 21:37 Inactive
@github-actions github-actions bot had a problem deploying to Preview - journeys-admin January 5, 2026 21:37 Failure
@github-actions github-actions bot temporarily deployed to Preview - resources January 5, 2026 21:37 Inactive
@github-actions github-actions bot temporarily deployed to Preview - videos-admin January 5, 2026 21:37 Inactive
@blacksmith-sh
Copy link
Contributor

blacksmith-sh bot commented Jan 5, 2026

Found 3 test failures on Blacksmith runners:

Failures

Test View Logs
EditorContext › EditorProvider/should set initial state View Logs
EditorContext › reducer/
SetSelectedBlockAction › should change to content view when block selected
View Logs
src/smoke/create-journey.spec.ts/admin can create a journey View Logs

Fix in Cursor

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys ✅ Ready journeys preview Tue Jan 6 11:06:03 NZDT 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
watch ✅ Ready watch preview Tue Jan 6 11:05:01 NZDT 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
resources ✅ Ready resources preview Tue Jan 6 11:05:00 NZDT 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
videos-admin ✅ Ready videos-admin preview Tue Jan 6 11:04:49 NZDT 2026

@github-actions github-actions bot temporarily deployed to Preview - videos-admin January 5, 2026 21:47 Inactive
@github-actions github-actions bot had a problem deploying to Preview - journeys-admin January 5, 2026 21:47 Failure
@github-actions github-actions bot temporarily deployed to Preview - resources January 5, 2026 21:47 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys January 5, 2026 21:47 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys-admin January 5, 2026 22:03 Inactive
@github-actions github-actions bot temporarily deployed to Preview - resources January 5, 2026 22:03 Inactive
@github-actions github-actions bot temporarily deployed to Preview - videos-admin January 5, 2026 22:03 Inactive
@github-actions github-actions bot temporarily deployed to Preview - journeys January 5, 2026 22:03 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The latest updates on your projects.

Name Status Preview Updated (UTC)
journeys-admin ✅ Ready journeys-admin preview Tue Jan 6 11:07:18 NZDT 2026

@csiyang csiyang marked this pull request as draft January 6, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants